Skip to content

Commit

Permalink
wip
Browse files Browse the repository at this point in the history
  • Loading branch information
lkostrowski committed Sep 30, 2024
1 parent cd25984 commit 5791757
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ type AvataxOrderConfirmedPayload = {
/**
* @deprecated use `SaleorOrderConfirmedEvent` instead
*/
order: DeprecatedOrderConfirmedSubscriptionFragment;
confirmedOrderEvent: SaleorOrderConfirmedEvent;
};
type AvataxOrderConfirmedResponse = CreateOrderResponse;
Expand Down Expand Up @@ -53,7 +52,6 @@ export class AvataxOrderConfirmedAdapter
this.logger.debug("Transforming the Saleor payload for creating order with AvaTax...");

const target = await this.avataxOrderConfirmedPayloadService.getPayload(
payload.order,
payload.confirmedOrderEvent,
config,
authData,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,16 +56,11 @@ export class AvataxOrderConfirmedPayloadTransformer {
return err(new TaxBadPayloadError("OrderConfirmedPayload has no shipping or billing address"));

Check failure on line 56 in apps/avatax/src/modules/avatax/order-confirmed/avatax-order-confirmed-payload-transformer.ts

View workflow job for this annotation

GitHub Actions / test

src/modules/avatax/order-confirmed/avatax-order-confirmed-payload-transformer.test.ts > AvataxOrderConfirmedPayloadTransformer > returns document type of SalesInvoice when isDocumentRecordingEnabled is true

TaxBadPayloadError: OrderConfirmedPayload has no shipping or billing address ❯ AvataxOrderConfirmedPayloadTransformer.getSaleorAddress src/modules/avatax/order-confirmed/avatax-order-confirmed-payload-transformer.ts:56:16 ❯ AvataxOrderConfirmedPayloadTransformer.transform src/modules/avatax/order-confirmed/avatax-order-confirmed-payload-transformer.ts:90:33 ❯ src/modules/avatax/order-confirmed/avatax-order-confirmed-payload-transformer.test.ts:38:21 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Serialized Error: { sentrySeverity: 'error' }

Check failure on line 56 in apps/avatax/src/modules/avatax/order-confirmed/avatax-order-confirmed-payload-transformer.ts

View workflow job for this annotation

GitHub Actions / test

src/modules/avatax/order-confirmed/avatax-order-confirmed-payload-transformer.test.ts > AvataxOrderConfirmedPayloadTransformer > returns document type of SalesOrder when isDocumentRecordingEnabled is false

TaxBadPayloadError: OrderConfirmedPayload has no shipping or billing address ❯ AvataxOrderConfirmedPayloadTransformer.getSaleorAddress src/modules/avatax/order-confirmed/avatax-order-confirmed-payload-transformer.ts:56:16 ❯ AvataxOrderConfirmedPayloadTransformer.transform src/modules/avatax/order-confirmed/avatax-order-confirmed-payload-transformer.ts:90:33 ❯ src/modules/avatax/order-confirmed/avatax-order-confirmed-payload-transformer.test.ts:49:21 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Serialized Error: { sentrySeverity: 'error' }

Check failure on line 56 in apps/avatax/src/modules/avatax/order-confirmed/avatax-order-confirmed-payload-transformer.ts

View workflow job for this annotation

GitHub Actions / test

src/modules/avatax/order-confirmed/saleor-order-to-avatax-lines-transformer.test.ts > AvataxOrderConfirmedPayloadTransformer > returns document type of SalesInvoice when isDocumentRecordingEnabled is true

TaxBadPayloadError: OrderConfirmedPayload has no shipping or billing address ❯ AvataxOrderConfirmedPayloadTransformer.getSaleorAddress src/modules/avatax/order-confirmed/avatax-order-confirmed-payload-transformer.ts:56:16 ❯ AvataxOrderConfirmedPayloadTransformer.transform src/modules/avatax/order-confirmed/avatax-order-confirmed-payload-transformer.ts:90:33 ❯ src/modules/avatax/order-confirmed/avatax-order-confirmed-payload-transformer.test.ts:38:21 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Serialized Error: { sentrySeverity: 'error' }

Check failure on line 56 in apps/avatax/src/modules/avatax/order-confirmed/avatax-order-confirmed-payload-transformer.ts

View workflow job for this annotation

GitHub Actions / test

src/modules/avatax/order-confirmed/saleor-order-to-avatax-lines-transformer.test.ts > AvataxOrderConfirmedPayloadTransformer > returns document type of SalesOrder when isDocumentRecordingEnabled is false

TaxBadPayloadError: OrderConfirmedPayload has no shipping or billing address ❯ AvataxOrderConfirmedPayloadTransformer.getSaleorAddress src/modules/avatax/order-confirmed/avatax-order-confirmed-payload-transformer.ts:56:16 ❯ AvataxOrderConfirmedPayloadTransformer.transform src/modules/avatax/order-confirmed/avatax-order-confirmed-payload-transformer.ts:90:33 ❯ src/modules/avatax/order-confirmed/avatax-order-confirmed-payload-transformer.test.ts:49:21 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Serialized Error: { sentrySeverity: 'error' }
}
async transform({
order,
confirmedOrderEvent,
avataxConfig,
matches,
discountsStrategy,
}: {
/**
* @deprecated
*/
order: DeprecatedOrderConfirmedSubscriptionFragment;
confirmedOrderEvent: SaleorOrderConfirmedEvent;
avataxConfig: AvataxConfig;
matches: AvataxTaxCodeMatches;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
import { AuthData } from "@saleor/app-sdk/APL";

import {
DeprecatedOrderConfirmedSubscriptionFragment,
SaleorOrderConfirmedEvent,
} from "../../saleor";
import { SaleorOrderConfirmedEvent } from "../../saleor";
import { CreateTransactionArgs } from "../avatax-client";
import { AvataxConfig } from "../avatax-connection-schema";
import { PriceReductionDiscountsStrategy } from "../discounts";
Expand All @@ -22,7 +19,6 @@ export class AvataxOrderConfirmedPayloadService {
}

async getPayload(
order: DeprecatedOrderConfirmedSubscriptionFragment,
confirmedOrderEvent: SaleorOrderConfirmedEvent,
avataxConfig: AvataxConfig,
authData: AuthData,
Expand All @@ -31,7 +27,6 @@ export class AvataxOrderConfirmedPayloadService {
const matches = await this.getMatches(authData);

return this.avataxOrderConfirmedPayloadTransformer.transform({
order,
confirmedOrderEvent,
avataxConfig,
matches,
Expand Down

0 comments on commit 5791757

Please sign in to comment.