SAK-50917 WC SakaiGrader when grading move peer review rubrics to an accordion #13257
+50
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ern
changed the title
ern
changed the title
|
@st-manu Screenshots look great! |
adrianfish
requested changes
Feb 3, 2025
| <div> | ||
| <span class="fw-bold me-2">${this._i18n.grade}</span> | ||
| <span>${pr.scoreDisplay}</span> | ||
| <div class="accordion" id="accordionPeerReviews"> |
There was a problem hiding this comment.
please use kebab case for all html element ids
| <div class="accordion" id="accordionPeerReviews"> | ||
| ${this._submission.peerReviews.map(pr => html` | ||
| <div class="accordion-item"> | ||
| <h2 class="accordion-header" id="peerHeading-${pr.assessorUserId}"> |
| <div> | ||
| <span class="fw-bold me-2">${this._i18n.grade}</span> | ||
| <span>${pr.scoreDisplay}</span> | ||
| <div class="accordion" id="accordionPeerReviews"> |
There was a problem hiding this comment.
Suggested change
| <div class="accordion" id="accordionPeerReviews"> | |
| <div class="accordion" id="peer-reviews"> |
| <div class="accordion" id="accordionPeerReviews"> | ||
| ${this._submission.peerReviews.map(pr => html` | ||
| <div class="accordion-item"> | ||
| <h2 class="accordion-header" id="peerHeading-${pr.assessorUserId}"> |
There was a problem hiding this comment.
Suggested change
| <h2 class="accordion-header" id="peerHeading-${pr.assessorUserId}"> | |
| <h2 class="accordion-header" id="peer-heading-${pr.assessorUserId}"> |
| ${pr.assessorDisplayName} | ||
| </button> | ||
| </h2> | ||
| <div id="peerCollapse-${pr.assessorUserId}" class="accordion-collapse collapse" aria-labelledby="peerHeading-${pr.assessorUserId}" data-bs-parent="#accordionPeerReviews"> |
There was a problem hiding this comment.
Suggested change
| <div id="peerCollapse-${pr.assessorUserId}" class="accordion-collapse collapse" aria-labelledby="peerHeading-${pr.assessorUserId}" data-bs-parent="#accordionPeerReviews"> | |
| <div id="peer-collapse-${pr.assessorUserId}" class="accordion-collapse collapse" aria-labelledby="peer-heading-${pr.assessorUserId}" data-bs-parent="#peer-reviews"> |
| ${this._submission.peerReviews.map(pr => html` | ||
| <div class="accordion-item"> | ||
| <h2 class="accordion-header" id="peerHeading-${pr.assessorUserId}"> | ||
| <button class="accordion-button" type="button" data-bs-toggle="collapse" data-bs-target="#peerCollapse-${pr.assessorUserId}" aria-expanded="true" aria-controls="peerCollapse-${pr.assessorUserId}"> |
There was a problem hiding this comment.
Suggested change
| <button class="accordion-button" type="button" data-bs-toggle="collapse" data-bs-target="#peerCollapse-${pr.assessorUserId}" aria-expanded="true" aria-controls="peerCollapse-${pr.assessorUserId}"> | |
| <button class="accordion-button" type="button" data-bs-toggle="collapse" data-bs-target="#peer-collapse-${pr.assessorUserId}" aria-expanded="true" aria-controls="peer-collapse-${pr.assessorUserId}"> |
| tool-id="${this.toolId}" | ||
| entity-id="${this.entityId}" | ||
| instructor="true" | ||
| is-peer-or-self="true" |
There was a problem hiding this comment.
This is a boolean attribute, so you dont need the string value
| evaluated-item-owner-id="${this._submission.groupId || this._submission.firstSubmitterId}"> | ||
| </sakai-rubric-student> | ||
| <hr class="itemSeparator"> | ||
| ` : ""} |
There was a problem hiding this comment.
Suggested change
| ` : ""} | |
| ` : nothing} |
| </div> | ||
| <div class="mt-2 mb-2 fw-bold">${this._i18n.reviewer_comments}</div> | ||
| <div>${unsafeHTML(pr.comment)}</div> | ||
| ${pr.attachmentUrlList && pr.attachmentUrlList.length > 0 ? html` |
There was a problem hiding this comment.
Suggested change
| ${pr.attachmentUrlList && pr.attachmentUrlList.length > 0 ? html` | |
| ${pr.attachmentUrlList?.length > 0 ? html` |
|
thank you for the review @adrianfish |
adrianfish
reviewed
Feb 4, 2025
| tool-id="${this.toolId}" | ||
| entity-id="${this.entityId}" | ||
| instructor="true" | ||
| is-peer-or-self="true" |
There was a problem hiding this comment.
Suggested change
| is-peer-or-self="true" | |
| is-peer-or-self |
There was a problem hiding this comment.
I wanted to make sure it was still working before making the change since the rest of the rubrics use the string, but I can't test it right now
There was a problem hiding this comment.
Boolean attributes can not have a string value. is-peer-or-self="false" would still be positive
There was a problem hiding this comment.
There was a problem hiding this comment.
understood! change made, thanks @adrianfish
…w rubric when grading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sakaiproject.atlassian.net/browse/SAK-50917
After adding the rubrics, the content of each peer review may be too lengthy to display all of them expanded. I have changed the format to an accordion (as it is in the classic grader).