sigal serve --browser : open in your default browser #516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
First, thank you very much for maintaining this tool.
Thanks yo you, yesterday I was able to very quickly setup a web gallery that perfectly suited my need.
This very short contribution introduces a hand
--browser
/-b
flag to thesigal serve
command, that opens the sigal gallery in the user default web brower, using the standard Python module webbrowser.I did not add a unit test to
tests/test_cli.py
, because it seemed difficult to me to test the standard behaviour of thewebbrowser
stanbdard package.If need be, I can add one that ensure that
webbrowser.open()
gets called, using a mock.