Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds flush-cache and several minor changes #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Adds flush-cache and several minor changes #6

wants to merge 4 commits into from

Conversation

luislobo
Copy link
Collaborator

  1. Adds flush-cache
  2. Removes // placeholders
  3. Fixes references to some URLs
  4. Made all tests use database Update pre-connection error catching to adjust for change in redis 2.8.0 #15
  5. Replaced use of destroyKeys with flushCache on before and after tests
  6. Commented what options can be added to a redis connection string
  7. Moved the example in README to a separate file in an examples folder.

@luislobo
Updated to the latest redis module, so that we can use more options i…
efcebef 
…n the url
@luislobo
Adds flush-cache and several minor changes
c4d7646 
Adds flush-cache
Removes // placeholders
Fixes references to some URLs
Made all tests use database sailshq#15
Replaced use of destroyKeys with flushCache on before and after tests
Commented what options can be added to a redis connection string
Moved the example in README to a separate file in an examples folder.
luislobo
luislobo commented Dec 22, 2016
View reviewed changes
Copy link
Collaborator Author

@luislobo luislobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikermcneil just in case you missed this one

@mikermcneil
Copy link
Member

@luislobo slowly catching up on everything else, hope to get a chance to look at this soon

@luislobo
Copy link
Collaborator Author

@mikermcneil np, let me know if you need some help around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luislobo @mikermcneil