Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few typos and double-spacing in the man page #560

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Silejonu
Copy link

No description provided.

Fix a few typos in the man page
@cebtenzzre
Copy link
Contributor

It looks like since 555060f there are some remaining references to -pp, which is no longer different from -p. There are a total of six in docs, this PR only changes one.

Removed the remaining mentions of the deprecated option -pp
Corrected a mention of the deprecated option -pp
Corrected mentions of the deprecated option -pp
@Silejonu
Copy link
Author

Silejonu commented Feb 14, 2022

It looks like since 555060f there are some remaining references to -pp, which is no longer different from -p. There are a total of six in docs, this PR only changes one.

You're right, I added the remaining ones that I feel comfortable touching.

@Silejonu
Copy link
Author

There are a few remaining instances of -pp in the source code, but I'm not sure they should be corrected and/or how they should be:

CHANGELOG.md:- -pp is now silently permitted, but is the same as -p
CHANGELOG.md:* Paranoia option -pp (use -p)
CHANGELOG.md:  "paranoid" (byte-by-byte) file comparison method (option -pp), which is
tests/test_formatters/test_others.py:    for silly_option in ['-ppp', '-PPPP']:
po/rmlint.pot:msgid "Only up to -pp or down to -PP flags allowed"
po/fr.po:msgid "Only up to -pp or down to -PP flags allowed"
po/fr.po:msgstr "Seules les options de -ppp à -P sont autorisées"
po/fr.po:msgstr "Seules les options de -ppp à -P sont autorisées"
po/es.po:msgid "Only up to -pp or down to -PP flags allowed"
po/es.po:msgstr "Sólo banderas hasta -pp o menores a -PP está permitido"
po/es.po:msgstr "Sólo banderas hasta -pp o menores a -PP está permitido"
po/de.po:msgid "Only up to -pp or down to -PP flags allowed"

@cebtenzzre
Copy link
Contributor

The changelog probably shouldn't be modified and the test is intentionally using odd yet supported paranoia flags. The .po files have old translations in them that can only really be dealt with by making rmlint.pot empty, running scons xgettext to regenerate it, then using msgattrib as described here to mark the unused translations obsolete and optionally delete them, for each .po file.
But I'm not sure how the maintainers like to manage translations so it may be best to leave them alone for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants