Fix the new release workflow by escaping special characters #39288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwankyu
changed the title
kwankyu
changed the title
|
@soham30rane would you review? |
|
Documentation preview for this PR (built with commit cf878ac; changes) is ready! 🎉 |
kwankyu
changed the title
|
Thanks! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 7, 2025
…aracters
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
The new release creation workflow introduced by
sagemath#39194 failed for the latest
release:
https://github.com/sagemath/sage/actions/runs/12612595224/job/3514974517
9
with the message "Problems parsing JSON". See the "Create release" step.
Reported by passagemath/passagemath#638
We fix it by escaping special characters in `release_notes` for json
input.
test: https://github.com/kwankyu/sage/releases/tag/10.7.beta3
test workflow run:
https://github.com/kwankyu/sage/actions/runs/12620257460/job/35165981375
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#39288
Reported by: Kwankyu Lee
Reviewer(s): Soham Rane
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 9, 2025
…aracters
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
The new release creation workflow introduced by
sagemath#39194 failed for the latest
release:
https://github.com/sagemath/sage/actions/runs/12612595224/job/3514974517
9
with the message "Problems parsing JSON". See the "Create release" step.
Reported by passagemath/passagemath#638
We fix it by escaping special characters in `release_notes` for json
input.
test: https://github.com/kwankyu/sage/releases/tag/10.7.beta3
test workflow run:
https://github.com/kwankyu/sage/actions/runs/12620257460/job/35165981375
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#39288
Reported by: Kwankyu Lee
Reviewer(s): Soham Rane
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 10, 2025
…aracters
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
The new release creation workflow introduced by
sagemath#39194 failed for the latest
release:
https://github.com/sagemath/sage/actions/runs/12612595224/job/3514974517
9
with the message "Problems parsing JSON". See the "Create release" step.
Reported by passagemath/passagemath#638
We fix it by escaping special characters in `release_notes` for json
input.
test: https://github.com/kwankyu/sage/releases/tag/10.7.beta3
test workflow run:
https://github.com/kwankyu/sage/actions/runs/12620257460/job/35165981375
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#39288
Reported by: Kwankyu Lee
Reviewer(s): Soham Rane
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new release creation workflow introduced by #39194 failed for the latest release:
https://github.com/sagemath/sage/actions/runs/12612595224/job/35149745179
with the message "Problems parsing JSON". See the "Create release" step. Reported by passagemath/passagemath#638
We fix it by escaping special characters in
release_notesfor json input.test: https://github.com/kwankyu/sage/releases/tag/10.7.beta3
test workflow run: https://github.com/kwankyu/sage/actions/runs/12620257460/job/35165981375
📝 Checklist
⌛ Dependencies