[Certora Audit] G-01. OwnerManager.removeOwner(): 1 SLOAD can be saved in the normal path
#888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remedcu
changed the title
OwnerManager.removeOwner(): 1 SLOAD can be saved in the normal pathOwnerManager.removeOwner(): 1 SLOAD can be saved in the normal path
mmv08
approved these changes
Jan 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a small but important change to the
removeOwnerfunction in theOwnerManagercontract. The change optimizes the decrement operation for theownerCountvariable.The previous code reads from storage twice with the
ownerCountvariable. By doing pre-decrement (which is cheaper than post-decrement), we can save on 1 SLOAD.Optimization:
contracts/base/OwnerManager.sol: Modified theremoveOwnerfunction to use pre-decrement forownerCountto improve efficiency and ensure the threshold check is performed correctly.