[Certora Audit] I-02. Some comments say keccak instead of keccak256
#886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to comments in the Solidity smart contracts to clarify the usage of the
keccak256function. The changes ensure that the comments accurately reflect the encoding process used in the contracts.Changes to comments for clarity:
contracts/common/SecuredTokenTransfer.sol: Updated the comment to specify that0xa9059cbbis thebytes4encoding ofkeccak256("transfer(address,uint256)").contracts/proxies/SafeProxy.sol: Updated the comment to specify that0xa619486eis thebytes4encoding ofkeccak256("masterCopy()").