Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment the execTransaction rule #705

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Nov 20, 2023

A follow up on: #702

It uncomments the rule the ghost was meant for and adds a public method for the summarized method (summaries only work for internal methods). Removes some unused methods.

@mmv08 mmv08 requested review from a team, rmeissner, nlordell, akshay-ap and remedcu and removed request for a team November 20, 2023 10:58
@coveralls
Copy link

coveralls commented Nov 20, 2023

Pull Request Test Coverage Report for Build 6955643362

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.567%

Totals Coverage Status
Change from base Build 6928337365: 0.0%
Covered Lines: 397
Relevant Lines: 405

💛 - Coveralls

@mmv08
Copy link
Member Author

mmv08 commented Nov 20, 2023

Hmm, this is strange. It worked fine on my computer with the cli version 4.13.1.

@mmv08 mmv08 force-pushed the fv/adjust-execTransactionRule branch from 4a0ece2 to fb37106 Compare November 22, 2023 09:57
@mmv08 mmv08 merged commit fec4b80 into main Nov 22, 2023
20 checks passed
@mmv08 mmv08 deleted the fv/adjust-execTransactionRule branch November 22, 2023 10:16
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants