Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update certora.yml to pin the cli version #697

Closed
wants to merge 2 commits into from

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Nov 9, 2023

The certora-cli v5 release on 15th Nov has some breaking changes that can lead to CI runs failing. To avoid these failures, we must change run: pip install certora-cli to run: pip3 install certora-cli==4.13.1 in certora.yml under .github/workflows. This will ensure there are no failures due to the new release.

EDIT:
For some reason, the coveralls action started failing with an error.
Example run: https://github.com/safe-global/safe-contracts/actions/runs/6811949628/job/18526604192?pr=696

I updated our coveralls action based on an example for parallel actions at https://github.com/marketplace/actions/coveralls-github-action and https://docs.coveralls.io/parallel-builds (was linked in the failed run)

@mmv08 mmv08 changed the title Ci/pin certora proper parallel coverage Update certora.yml to pin the cli version Nov 9, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6814671749

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.307%

Totals Coverage Status
Change from base Build 6720462527: 0.0%
Covered Lines: 400
Relevant Lines: 409

💛 - Coveralls

@mmv08
Copy link
Member Author

mmv08 commented Nov 9, 2023

I created this PR to see if the "Waiting for status to be reported" would fix itself. It didn't, so I'm closing the PR.

@mmv08 mmv08 closed this Nov 9, 2023
@mmv08 mmv08 deleted the ci/pin-certora-proper-parallel-coverage branch November 9, 2023 16:40
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants