Add pre-commit hook for linting and formatting #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6588754092
💛 - Coveralls |
mmv08
reviewed
Oct 20, 2023
.husky/pre-commit
Outdated
Comment on lines
7
to
19
| # prevent it.only or describe.only commited | ||
| if [ "$allowonlytests" != "true" ] && | ||
| test $(git diff --cached | grep -E "\b(it|describe).only\(" | wc -l) != 0 | ||
| then | ||
| cat <<\EOF | ||
| Error: Attempt to add it.only or describe.only - which may disable all other tests | ||
|
|
||
| If you know what you are doing you can disable this check using: | ||
|
|
||
| git config hooks.allowonlytests true | ||
| EOF | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
why remove the check for it.only in tests?
There was a problem hiding this comment.
I thought this was a placeholder and not used. I made husky regenerate the file from scratch. Do you think this is relevant?
There was a problem hiding this comment.
Well, it prevented me from accidentally pushing only to a PR. I use it quite often to debug a specific test and avoid running other ones.
There was a problem hiding this comment.
I understand, I added the check back
- Check linting and formatting of Typescript and Solidity files - Split linting and formatting checking on Github Actions - Refactor `NODE_VERSION` on Github Actions into an environment variable
nlordell
reviewed
Oct 20, 2023
Comment on lines
+1
to
+2
| #!/usr/bin/env sh | ||
| . "$(dirname -- "$0")/_/husky.sh" |
nlordell
approved these changes
Oct 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NODE_VERSIONon Github Actions into an environment variable