Add datasource for Safe Decoder Service #2313
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamacook
force-pushed
the
safe-decoder-datasource
branch
from
ef803f7 to
4b4cb62
Compare
iamacook
commented
Jan 29, 2025
iamacook
commented
Jan 29, 2025
iamacook
commented
Feb 4, 2025
|
|
||
| export const DataDecodedSchema = z.lazy(() => | ||
| z.object(BaseDataDecodedSchemaShape).extend({ | ||
| accuracy: z.enum([...Accuracy, 'UNKNOWN']).catch('UNKNOWN'), |
There was a problem hiding this comment.
This is the only thing that's changed in comparison to the existing DataDecoded entity. I think it's better we validate the entity correctly nonetheless. What do we think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The new Safe Decoder Service improves upon the decoder of the Safe Transaction Service. As such, we intend to migrate to it.
This lays the foundation of usage, by creating a datasource (with manager) and base repository for validating the responses.
Changes
safeDataDecoder.baseUri(test) configurationDataDecoderApiManagerinterface, implementation and moduleDataDecoderApiinterface, implementation and moduleDataDecodedand `Contract, with inferred types and buildersDataDecoderRepositoryfor accessing/validating datasource responses