Suggest improvements #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imported sled database interface from JetRPC
- Builtin erc20 abi used Ethereum Binance Pegged Contract. - Wrapper struct for erc20 token - get_balance for erc20 token - refactored sled db interface - set gateway callback function to be async - drafted poller function (untested) - invoice struct todo: test the poller by using this as external library and also draft test cases to test the poller to the extent possible without involving private keys into the repo
- changed project structure to prevent internal interfaces from being exported to the public API. - added custom expiration for invoices - added descriptive names for payment gateways
Refactored according to suggestions by clippy.
Added description of how the library functions
- Deprecated rust-web3 in favor of alloy-rs due to rust-web3 being deprecated in the future - Replaced eth abi with IERC20 abi. - Transfer paid invoice funds to treasury when paid TODO: in the near future token transfers also need to be included so that it is possible to configure payments via tokens.
Add basic rust pipeline
biryukovmaxim
suggested changes
May 10, 2024
- use RUST_LOG - simplify functions - convert sled errors to custom db error - deprecate audit module - reduce cloning and replace with ref usage - add zeroize type for wallet bytes
|
@biryukovmaxim Please review new commits for your requested changes |
…xless feat: make callback structure mutexless
Co-Authored-By: Maxim <[email protected]>
biryukovmaxim
approved these changes
May 10, 2024
saefstroem
added a commit
that referenced
this pull request
May 10, 2024
Merge pull request #1 from starkbamse/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please suggest improvements in alignment with release.