Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]feat/added dark-light theme and toggle button #418

Conversation

Dev-AkshatGupta
Copy link
Contributor

Title and Issue number

#393 Add dark and light mode for the host application
Title: feat/ dark - light theme and toggle button

Issue No. : #393

Code Stack: Js, CSS

Close #<393>

Description:-

  1. Using Lucid for icons instead of Fontawesome found it better.
  2. Used Context for switching theme.
  3. Example in a video.
    https://github.com/sadanandpai/frontend-mini-challenges/assets/53713926/cf020e72-100f-404c-9d68-850d1c63468a

Copy link

netlify bot commented Mar 3, 2024

Deploy Preview for frontend-mini-challenges failed.

Name Link
🔨 Latest commit 4d560d7
🔍 Latest deploy log https://app.netlify.com/sites/frontend-mini-challenges/deploys/65e4b33539f91d00086752b4

@sadanandpai
Copy link
Owner

conflicts

@sadanandpai
Copy link
Owner

@Dev-AkshatGupta
image

@Dev-AkshatGupta Dev-AkshatGupta changed the title feat/added dark-light theme and toggle button [WIP]feat/added dark-light theme and toggle button Mar 4, 2024
@Dev-AkshatGupta
Copy link
Contributor Author

conflicts

@Dev-AkshatGupta image

Hey Sadanand I added WIP for the same I know why it's happening and rectified it locally. Just having some trouble with the git configuration I am figuring that out. Will sqash all commits in one. Thanks for reviewing.

@Dev-AkshatGupta
Copy link
Contributor Author

Opened a new pr with conflicts solved and commits squashed
#419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants