Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React] Added Nested Comments Project #416

Merged
merged 7 commits into from
Apr 22, 2024

Conversation

Akshayone8
Copy link
Contributor

@Akshayone8 Akshayone8 commented Mar 3, 2024

Title and Issue number

Title : Nested Comments

Issue No. : #416

Code Stack : React

Close #<issue_no>

Screenshot 2024-03-03 at 11 26 52 AM # Checklist:
  • I have mentioned the issue number in my Pull Request.
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have created a helpful and easy to understand README.md
  • [] I have updated the Index.html file for my contribution

Copy link

netlify bot commented Mar 3, 2024

Deploy Preview for frontend-mini-challenges ready!

Name Link
🔨 Latest commit a52bdbe
🔍 Latest deploy log https://app.netlify.com/sites/frontend-mini-challenges/deploys/6622a71f5779bc0008241cb2
😎 Deploy Preview https://deploy-preview-416--frontend-mini-challenges.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sadanandpai
Copy link
Owner

@Akshayone8 can we also have reply & delete options

@Akshayone8
Copy link
Contributor Author

@sadanandpai Added reply and delete feature.
Screenshot 2024-03-04 at 6 10 59 PM

@sadanandpai
Copy link
Owner

There are conflicts.
The comments reply is not working properly. Some comments after adding are not showing up but shows after cancel click

@Akshayone8
Copy link
Contributor Author

There are conflicts. The comments reply is not working properly. Some comments after adding are not showing up but shows after cancel click

@sadanandpai "Thank you for your patience. I've addressed the issue with the comments reply functionality and made the necessary changes. Please try using it again, and let me know if the problem persists or if you have any further feedback. Your input is valuable in ensuring a smooth user experience."

Screen.Recording.2024-03-04.at.10.42.53.PM.mov

@Akshayone8
Copy link
Contributor Author

Title : Navbar

Issue No. :

Code Stack : React

Close #<issue_no>

@sadanandpai Added new React challenge - Navbar

Screenshot 2024-03-05 at 9 20 13 AM Screenshot 2024-03-05 at 9 20 48 AM

@sadanandpai
Copy link
Owner

sadanandpai commented Mar 5, 2024

We can raise one PR for one task. Let's keep this only for Nested comments.
Navbar can be taken separately. Else due to conflicts or bugs in one task other will be blocked

@sadanandpai
Copy link
Owner

@Akshayone8 conflicts

@Akshayone8
Copy link
Contributor Author

Hi @sadanandpai I have resolved the conflicts can u verify now.

@sadanandpai
Copy link
Owner

@Akshayone8 There is a major bug

temp.mp4

Also can you plz make enter key to work after typing

@arpansaha13
Copy link
Collaborator

A squash and merge could keep the commit history clean...

@arpansaha13 arpansaha13 changed the title Added Nested Comments Project #416 [React] Added Nested Comments Project #416 Apr 19, 2024
@arpansaha13 arpansaha13 changed the title [React] Added Nested Comments Project #416 [React] Added Nested Comments Project Apr 19, 2024
@sadanandpai sadanandpai merged commit 6a30565 into sadanandpai:main Apr 22, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants