Allow anyone to call withdraw function #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
andreivladbrg
force-pushed
the
main
branch
2 times, most recently
from
9f8f40a
to
1391fe9
Compare
andreivladbrg
force-pushed
the
refactor/withdraw-public
branch
from
51892e3
to
40cca4a
Compare
andreivladbrg
force-pushed
the
refactor/withdraw-public
branch
from
40cca4a
to
ec4d89c
Compare
refactor: improve custom error names docs: udpate natspec in withdraw function chore: improve wording in explanatory comments test: update withdraw tree and tests accordingly
andreivladbrg
force-pushed
the
refactor/withdraw-public
branch
from
ec4d89c
to
f470114
Compare
test: don't change the timestampt in deposit invariant handler
andreivladbrg
force-pushed
the
refactor/withdraw-public
branch
from
f470114
to
c79b497
Compare
smol-ninja
requested changes
Apr 20, 2024
There was a problem hiding this comment.
I have partially reviewed the PR. Please see comments below:
During the review, I also made changes locally which I have pushed to this PR. If you agree with suggestions, we can incorporate those changes from that PR.
… fix comment (#48) * build: add script for deterministic deployment build: enable ffi cheatcode * build: replace ffi with stdJson * doc: fix comment * build: update bun lockfile * chore: capitalize StdJson file import --------- Co-authored-by: andreivladbrg <[email protected]>
|
Merged your PR here @smol-ninja, if everything looks good now, can we merge this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30