Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: return withdrawn amount and protocol fee #304

Merged
merged 4 commits into from
Oct 14, 2024
Merged

feat: return withdrawn amount and protocol fee #304

merged 4 commits into from
Oct 14, 2024

Commits on Oct 13, 2024

  1. feat: return amountWithdrawn and feeTaken in withdraw 

    test: DRY'ify Vars struct
    @smol-ninja
    smol-ninja committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    dba5478 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. refactor: follow somethingSomethingAmount pattern for variables naming 

    refactor: explicitness with protocolFeeAmount

Co-authored-by: Paul Razvan Berg <[email protected]>
    @smol-ninja @PaulRBerg
    smol-ninja and PaulRBerg committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    b178081 View commit details
    Browse the repository at this point in the history

  2. test: declare vars in Base contract 

    docs: polish natspecs for withdraw and withdrawMax

Co-authored-by: Andrei Vlad Birgaoanu <[email protected]>
    @smol-ninja @andreivladbrg
    smol-ninja and andreivladbrg committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    eb27ebb View commit details
    Browse the repository at this point in the history

  3. merge conflict

    @smol-ninja
    smol-ninja committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2087e0f View commit details
    Browse the repository at this point in the history