Change types and add modifier to getter #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smol-ninja
requested changes
Oct 10, 2024
tests/integration/concrete/depletion-time-of/depletionTimeOf.t.sol
Outdated
Show resolved
Hide resolved
andreivladbrg
force-pushed
the
fix/types-and-getter
branch
2 times, most recently
from
fa1b1af
to
4969ae9
Compare
|
@smol-ninja While going through the code again, I realized I made some errors in the fixes and force-pushed my initial commit (your review comments might be outdated now—sorry). These issues should have been addressed, but the changes caused some tests to break. I still need to debug that as well |
fix: add notNull in isTransferable getter fix: use uint256 in depletionTimeOf
andreivladbrg
force-pushed
the
fix/types-and-getter
branch
from
4969ae9
to
703b9ec
Compare
|
@smol-ninja just finished with the test fixes since this finding https://cantina.xyz/code/99ae802b-f05c-4e36-a1d1-240d5146649c/findings/8 is also related to the |
|
Sounds good. Took me a while to understand the context of finding. It was confusing to me. |
smol-ninja
requested changes
Oct 12, 2024
There was a problem hiding this comment.
- As we discussed over slack, given that
snapshotDebthas its own slot, are you not considering usinguint256for it, so as to avoid downcasting while storing to it? - Lets include https://cantina.xyz/code/99ae802b-f05c-4e36-a1d1-240d5146649c/findings/8 in this PR as well.
refactor: use uint256 for snapshot debt
@smol-ninja just pushed a new commit cdedfd1 |
andreivladbrg
changed the title
smol-ninja
requested changes
Oct 12, 2024
tests/integration/concrete/depletion-time-of/depletionTimeOf.tree
Outdated
Show resolved
Hide resolved
andreivladbrg
added a commit
that referenced
this pull request
Oct 15, 2024
* fix: use uint256 for scaledOngoingDebt fix: add notNull in isTransferable getter fix: use uint256 in depletionTimeOf * test: remove undeeded down casting * fix: use ">" in depletionTimeOf refactor: use uint256 for snapshot debt * address last review comments * test: lower the rps bound range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #295
Changes