Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IH: program-boilerplate: refactor programTrigger Error handling; repl… #139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ianhitchcock
Copy link
Contributor

…ace console.log with singleton logger; remove deprecated utility functions

Refactor programTrigger error handling to:

  • properly handle program validation errors
  • remove error stacks from api responses
  • use singleton logger instead of console.log

Other changes:

  • remove deprecated conversion utility files
  • increase test coverage

Listing this as a breaking change due to removing the deprecated functions and the slight change to the error responses

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

Links

  • Jira issue number: (PUT IT HERE)
  • Process.st launch checklist: (PUT IT HERE)

Checklists

Development

  • Prettier was run
  • The behaviour changes in the pull request are covered by specs
  • All tests related to the changed code pass in development

Paperwork

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has a Jira number
  • This pull request has a Process.st launch checklist
  • "Ready for review" label attached to the PR and reviewers pinged on Slack

Code review

  • Changes have been reviewed by at least one other engineer
  • Security impacts of this change have been considered

…ace console.log with singleton logger; remove deprecated utility functions
@ianhitchcock ianhitchcock force-pushed the ih/program-boilerplate-refactor branch from 74a9d38 to 40a5dc6 Compare March 31, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant