serendipity_sendMail: terminate headers with CRLF. #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, looks plausible. |
serendipity_sendMail() will concatenate additional headers to a string separated with LF (\n). That is not standard compliant, as RFC 5322 demands CRLF (\r\n). This has real life implications at least on PHP 8.2.20 with Exim 4.96, as all additional headers are appended to one single long header line, losing encoding information and more. Change LF to CRLF here. Fixes s9y#852. Signed-off-by: Thomas Hochstein <[email protected]>
|
Yeah, sorry. I'm a bit rusty. |
garvinhicking
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serendipity_sendMail() will concatenate additional headers to a string separated with LF (\n). That is not standard compliant, as RFC 5322 demands CRLF (\r\n).
This has real life implications at least on PHP 8.2.20 with Exim 4.96, as all additional headers are appended to one single long header line, losing encoding information and more.
Change LF to CRLF here.
Fixes #852.