Refs issue #5 Some classes are not supported anymore in Apache Flink v1.4 and were … #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exchanged: import org.apache.flink.hadoop.shaded.com.google.common.base.Strings; import org.apache.flink.hadoop.shaded.com.google.common.collect.Lists;
|
Sorry, totally lost sight of that PR. Wouldn't it make sense to also update the |
s1ck
reviewed
Apr 16, 2018
| @@ -199,10 +198,10 @@ public T setReadTimeout(int readTimeout) { | |||
| * Validates mandatory arguments. | |||
| */ | |||
| protected void validate() { | |||
| if (Strings.isNullOrEmpty(restURI)) { | |||
| if (restURI.isEmpty() || restURI == null) { | |||
There was a problem hiding this comment.
the restURI == null check should be in front. If it's null, the .isEmpty() call will throw a NPE. That's why the helper method is called nullOrEmpty ;)
also see here https://github.com/google/guava/blob/master/guava/src/com/google/common/base/Platform.java#L58-L60
added 2 commits
April 20, 2018 15:40
- POM updated to Flink v.1.4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…exchanged:
import org.apache.flink.hadoop.shaded.com.google.common.base.Strings;
import org.apache.flink.hadoop.shaded.com.google.common.collect.Lists;