Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ellama-make-flash-cards #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

geekodour
Copy link

Adds function to create flashcards from selected text in the buffer

Adds function to create flashcards from selected text in the buffer
@s-kostyaev
Copy link
Owner

Hi, @geekodour. Thank you for this PR. Have you signed the FSF
copyright assignment (CA)? I have a plan to move this project to GNU Elpa and all significant contributors should do it for that. Since this PR contains more than 15 loc, it matters. Sorry, that this not in Readme yet.

"Example:\n"
"* What is an apple?\n"
"A fruit"
))))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, move closing parens to previous line.

@s-kostyaev
Copy link
Owner

I have tried it, nice feature, thank you for contributing!

@s-kostyaev
Copy link
Owner

s-kostyaev commented Nov 7, 2023

Also, maybe it will be more useful if generation result will be in file in customized directory instead of ellama chat buffer? Or you mean later interactions with ellama about generated flash cards?

@geekodour
Copy link
Author

I think ellama-instant would be more appropriate but it's not accessible from my config as it's not auto-loaded?(was that intentional?)

I think ellama-instant makes more sense than ellama-chat because chat would have previous context and I would in the usecase of generating flashcard not want it to include previous context as I might be switching between different files which don't relate to each other.

On top of that sometimes it takes repeated attempts for it to respond as expected. (Eg. sometimes it'll return with not the response we want but re-running works etc., for all these usecase.

Otherwise, chat is also nice in the way that we could tell it to generate a flashcard somewhat differently in any case. (But everytime we trigger ellama-make-flash-cards it should be a fresh chat context, that I think we should ensure for better results.

Let me know what you think will be a suitable thing to do here? :)

Also, I've sent the mail to FSF, will let you know when they get back.

@s-kostyaev
Copy link
Owner

s-kostyaev commented Nov 8, 2023

If you need fresh context, I think ellama-instant will be better. It's not autoloaded because user doesn't need to use it interactively.

@s-kostyaev
Copy link
Owner

@geekodour Any updates? Or should we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants