-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CFC: Feature/mockk integration #188
base: master
Are you sure you want to change the base?
Conversation
rybalkinsd
commented
May 14, 2020
•
edited
Loading
edited
cc @neisip |
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
============================================
- Coverage 90.59% 85.10% -5.50%
- Complexity 127 131 +4
============================================
Files 42 44 +2
Lines 404 443 +39
Branches 49 63 +14
============================================
+ Hits 366 377 +11
- Misses 13 26 +13
- Partials 25 40 +15
Continue to review full report at Codecov.
|
*/ | ||
fun Response(init: okhttp3.Response.Builder.() -> Unit): okhttp3.Response { | ||
return okhttp3.Response.Builder().also(init).build() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No newline
Codcov tests are expected to fail now. Will bring more when we will discuss the API |
Moved further with mocks.
Option 2:
Pros:
Cons:
Option 1 was:
Will be great to here your thoughts @IVSivak @gokulchandra @DeviantBadge |
The first option looks like more commonly used. The second option may be confusing for someone, but it looks concise. |
67dbe86
to
7bd0ac7
Compare