-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle Retry-After header #151
Open
doyaaaaaken
wants to merge
14
commits into
rybalkinsd:master
Choose a base branch
from
doyaaaaaken:handling-retry-after
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e82234d
handle Retry-After header
doyaaaaaken 29905f2
rename variable and method
doyaaaaaken c29e53c
Merge branch 'master' into handling-retry-after
doyaaaaaken ab0ed64
Revert format change
doyaaaaaken 16a757b
fix bug: regard the unit of Retry-After as second (not millisec)
doyaaaaaken 642a488
refactor: simplify logic
doyaaaaaken 41714ab
rewrite test `delay increase with step`
doyaaaaaken c4c3397
enable to parse httpDate format's Retry-After header
doyaaaaaken ac1042f
separate parse logic by strategy
doyaaaaaken 173270d
Use ZonedDateTime in parse logic
doyaaaaaken d77de84
Merge branch 'master' into handling-retry-after
doyaaaaaken 74e2e84
remove unused code
doyaaaaaken 8312649
add test code
doyaaaaaken c3a0dc8
Merge branch 'master' into handling-retry-after
doyaaaaaken File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ package io.github.rybalkinsd.kohttp.interceptors | |
import okhttp3.Interceptor | ||
import okhttp3.Response | ||
import java.net.SocketTimeoutException | ||
import kotlin.math.max | ||
|
||
/** | ||
* Retry Interceptor | ||
|
@@ -21,7 +22,7 @@ class RetryInterceptor( | |
private val failureThreshold: Int = 3, | ||
private val invocationTimeout: Long = 0, | ||
private val ratio: Int = 1, | ||
private val errorStatuses: List<Int> = listOf(503, 504) | ||
private val errorStatuses: List<Int> = listOf(429, 503, 504) | ||
) : Interceptor { | ||
|
||
override fun intercept(chain: Interceptor.Chain): Response { | ||
|
@@ -34,7 +35,13 @@ class RetryInterceptor( | |
delay = performAndReturnDelay(delay) | ||
} | ||
val response = chain.proceed(request) | ||
if (!isRetry(response, attemptsCount)) return response | ||
|
||
val nextTime = calculateNextRetry(response, attemptsCount, delay, chain.readTimeoutMillis()) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I suggest to have two stages here:
Probably, we need to modify |
||
if (nextTime != null) { | ||
delay = nextTime | ||
} else { | ||
return response | ||
} | ||
} catch (e: SocketTimeoutException) { | ||
if (attemptsCount >= failureThreshold) throw e | ||
} | ||
|
@@ -52,6 +59,14 @@ class RetryInterceptor( | |
|
||
private fun shouldDelay(attemptsCount: Int) = invocationTimeout > 0 && attemptsCount > 0 | ||
|
||
internal fun isRetry(response: Response, attemptsCount: Int): Boolean = | ||
attemptsCount < failureThreshold && response.code() in errorStatuses | ||
internal fun calculateNextRetry(response: Response, attemptsCount: Int, delay: Long, maxDelayTime: Int): Long? { | ||
val retryAfter = response.header("Retry-After")?.toLongOrNull()?.let { it * 1000 } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
if (retryAfter != null && retryAfter > maxDelayTime) return null | ||
|
||
return if (attemptsCount < failureThreshold && response.code() in errorStatuses) { | ||
max(retryAfter ?: 0, delay) | ||
} else { | ||
null | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a room for improvement here.
if () statement else return
logic looks rather complicated