fix: call createPortal() on null tartget (#255)

* fix: call createPortal() on null target fixes #204 * Add tests --------- Co-authored-by: Ryan Seddon <[email protected]>
ryanseddon · May 24, 2024 · 759ccf1 · 759ccf1
1 parent 1b44f0a
commit 759ccf1
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/src/Frame.jsx b/src/Frame.jsx
@@ -128,6 +128,10 @@ export class Frame extends Component {
 
     const mountTarget = this.getMountTarget();
 
+    if (!mountTarget) {
+      return null;
+    }
+
     return [
       ReactDOM.createPortal(this.props.head, this.getDoc().head),
       ReactDOM.createPortal(contents, mountTarget)

diff --git a/test/Frame.spec.jsx b/test/Frame.spec.jsx
@@ -341,6 +341,23 @@ describe('The Frame Component', () => {
     );
   });
 
+  it("should render null when `this.getMountTarget()` can't resolve", done => {
+    const didMount = sinon.spy();
+    const getMountTarget = sinon
+      .stub(Frame.prototype, 'getMountTarget')
+      .returns(null);
+
+    div = document.body.appendChild(document.createElement('div'));
+
+    ReactDOM.render(<Frame contentDidMount={didMount} />, div);
+
+    setTimeout(() => {
+      expect(didMount.callCount).to.equal(0);
+      done();
+      getMountTarget.restore();
+    }, 100);
+  });
+
   it('should not error when parent components are reused', done => {
     div = document.body.appendChild(document.createElement('div'));