Bugfix some devicons icons #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are the fixed icons, apart from The reason for these strange edges are a 'careless' conversion to monochrome (a.k.a. Also affected is upstream's I feel I need to check all other icons systematically, these where just the visually conspicuous ones I found just by looking when fixing the PyTorch logo (see #1771). Some might follow later. Ping to @Snailedlt from Devicons; I know you are no designer but maybe this is somehow interesting upstream.
|
|
New list of icons to check manually: |
|
|
[why] A lot icons have visually obvious issues, small but visible. Often the source is a color svg and someone just made them monochrome for the plain version. But it is still different paths and not joined. That can lead to small glitches with the fontforge svg import. [how] Manually inspect some icons and recreate a new plain icon wich consists of one flat path. For Plotly we also update to the current logo with circles as ... circles and not some squiggly lines. Tomcat and Zig also get plain variants which they lack upstream. Fixes: #1771 Signed-off-by: Fini Jastrow <[email protected]>
[why] Some part of the path is not interpreted as hole. [how] Recreate full path parts by first breaking apart and then recombining the paths (manually in Inkscape). Fixes: #1760 Signed-off-by: Fini Jastrow <[email protected]>
Mostly double-points or gaps or overlaps. Manually fixed in Inkscape, mostly * join-points * path union * path break-apart && path exclusion Signed-off-by: Fini Jastrow <[email protected]>
$ fontforge generate 2>/dev/null Reading mapping file Found 496 entries Unpacking Devicons archive Mixing Vorillaz Devicons and possible fixes in Found 1743 svgs Using fixed svg for bitbucket-original.svg Using fixed svg for akka-plain.svg Using fixed svg for nodejs-plain.svg Using fixed svg for angularjs-plain.svg Using fixed svg for antdesign-plain.svg Using fixed svg for awk-plain.svg Using fixed svg for opera-plain.svg Using fixed svg for bash-plain.svg Using fixed svg for beats-plain.svg Using fixed svg for nginx-plain.svg Using fixed svg for yii-plain.svg Using fixed svg for firebase-plain.svg Using fixed svg for clojurescript-plain.svg Using fixed svg for cosmosdb-plain.svg Using fixed svg for mongodb-plain.svg Using fixed svg for rust-original.svg Using fixed svg for intellij-plain.svg Using fixed svg for materializecss-plain.svg Using fixed svg for datagrip-plain.svg Using fixed svg for electron-plain.svg Using fixed svg for figma-plain.svg Using fixed svg for goland-plain.svg Using fixed svg for googlecloud-plain.svg Using fixed svg for graphql-plain.svg Using fixed svg for hardhat-plain.svg Using fixed svg for hibernate-plain.svg Using fixed svg for homebrew-plain.svg Using fixed svg for jetbrains-plain.svg Using fixed svg for karma-plain.svg Using fixed svg for kibana-plain.svg Using fixed svg for latex-original.svg Using fixed svg for livewire-plain.svg Using fixed svg for llvm-plain.svg Using fixed svg for materialui-plain.svg Using fixed svg for matplotlib-plain.svg Using fixed svg for maven-plain.svg Using fixed svg for maya-plain.svg Using fixed svg for nimble-plain.svg Using fixed svg for norg-plain.svg Using fixed svg for nuxtjs-plain.svg Using fixed svg for okta-plain.svg Using fixed svg for playwright-plain.svg Using fixed svg for plotly-plain.svg Using fixed svg for portainer-original.svg Using fixed svg for postcss-original.svg Using fixed svg for puppeteer-plain.svg Using fixed svg for pytorch-original.svg Using fixed svg for quarkus-plain.svg Using fixed svg for qwik-plain.svg Using fixed svg for sdl-plain.svg Using fixed svg for sequelize-plain.svg Using fixed svg for sqldeveloper-plain.svg Using fixed svg for streamlit-plain.svg Using fixed svg for threejs-original.svg Using fixed svg for tomcat-plain.svg Using fixed svg for vagrant-plain.svg Using fixed svg for vuestorefront-plain.svg Using fixed svg for woocommerce-plain.svg Using fixed svg for zig-plain.svg Generating devicons.ttf with 496 glyphs Generating GlyphInfo i_dev.sh Finished Signed-off-by: Fini Jastrow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some icons have problems, fix this manually in Inkscape.
Not all icons checked, just the ones that catched my eye on visual inspection.
Requirements / Checklist
Issue number where discussion took place: #xxx
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)