Skip to content
This repository has been archived by the owner on Jul 1, 2023. It is now read-only.

add format and lint workflow #17

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add format and lint workflow #17

wants to merge 4 commits into from

Conversation

getchoo
Copy link
Collaborator

@getchoo getchoo commented May 7, 2023

this adds a format and lint workflow that uses black for python, prettier for js/html, and alejandra/deadnix/statix for nix, leveraging the pre-commit hooks we already have in the flake. formatting will be automatically applied and committed on push to a branch in the repo when possible

cachix is used here as well in order to cache the entire dev shell, making it more convenient for people to use and keeping ci times blazing fast 🚀 🔥

this will be a draft until #16 is merged or closed, since it would need a rebase in the case of the former done!

@getchoo getchoo force-pushed the add-format-lint branch from 5d2b564 to 0358d7e Compare May 7, 2023 02:50
getchoo added 3 commits May 7, 2023 13:53
this is required due to actions not being able to edit their own
contents, which can happen when formatting with prettier in ci
this doesn't work due to external modules used in the eslint
configuration
@getchoo getchoo force-pushed the add-format-lint branch from a872677 to cc245b1 Compare May 7, 2023 17:55
@getchoo getchoo marked this pull request as ready for review May 7, 2023 18:06
@getchoo getchoo requested a review from ryanccn as a code owner May 7, 2023 18:06
@getchoo
Copy link
Collaborator Author

getchoo commented May 7, 2023

workflows are good, not sure what happened with the status here 🤷🏻
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant