-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix subset param import #412
base: master
Are you sure you want to change the base?
Conversation
See failing test, i.e. code style. |
There is one remaining warning that is not easily fixable: I import _SubnetworkRecCell to do an isinstance check. Can this warning be ignored or how should I fix that? |
Actually, we should not do it this way. Note that this is a bit inconsistent to the behavior of |
What is the state here? |
Note: There is now the function |
d4351c2
to
497eeba
Compare
Ok, I removed @curufinwe @michelwi can you check it's ok, so that we can merge? |
Fix bug where custom_parameter_importer = "subset" would not operate on parameters inside rec layers.