fix(rs-wit-bindgen): do not fail on async I/O errors

Signed-off-by: Roman Volosatovs <[email protected]>
rvolosatovs · Jul 5, 2024 · ac39c7c · ac39c7c
1 parent bea73e2
commit ac39c7c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/wit-bindgen-rust/Cargo.toml b/crates/wit-bindgen-rust/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "wit-bindgen-wrpc-rust"
-version = "0.4.0"
+version = "0.4.1"
 description = """
 Rust bindings generator for wRPC, typically used through
 the `wit-bindgen-wrpc` crate's `generate!` macro.

diff --git a/crates/wit-bindgen-rust/src/interface.rs b/crates/wit-bindgen-rust/src/interface.rs
@@ -337,30 +337,32 @@ pub async fn serve_interface<T: {wrpc_transport}::Serve, U>(
                 self.src,
                 r#"
                         ).await {{
-                            Ok(returns) => {{
+                            Ok(results) => {{
                                 match tx("#,
             );
             if func.results.len() == 1 {
-                // wrap single-element returns into a tuple for correct indexing
-                self.push_str("(returns,)");
+                // wrap single-element results into a tuple for correct indexing
+                self.push_str("(results,)");
             } else {
-                self.push_str("returns");
+                self.push_str("results");
             }
             uwrite!(
                 self.src,
                 r#"
                                 ).await {{
                                     Ok(()) => {{
                                         if let Some(rx) = rx {{
-                                            rx.await??;
+                                            if let Err(err) = rx.await? {{
+                                                {tracing}::warn!(?err, "failed to receive async `{instance}.{wit_name}` invocation parameters");
+                                            }}
                                         }}
                                         continue;
                                     }}
                                     Err(err) => {{
                                         if let Some(rx) = rx {{
                                             rx.abort();
                                         }}
-                                        {tracing}::warn!(?err, "failed to send returns");
+                                        {tracing}::warn!(?err, "failed to transmit `{instance}.{wit_name}` invocation results");
                                     }}
                                 }}
                             }},