-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade semver of readable-stream from 3 to ^4.0.0 #113
base: master
Are you sure you want to change the base?
Conversation
@brycebaril @maxogden @rvagg @styfle Please Have a look at this PR |
package.json
Outdated
@@ -23,7 +23,7 @@ | |||
"author": "Rod Vagg <[email protected]> (https://github.com/rvagg)", | |||
"license": "MIT", | |||
"dependencies": { | |||
"readable-stream": "3" | |||
"readable-stream": "4.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"readable-stream": "4.2.0" | |
"readable-stream": "4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes Done. Please Review It @styfle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine although I don't have any authority here and didn't run the tests
@rvagg Please Review this PR |
🤦 CI is very out of date ... for a start, let's go with also the browser tests are broken, probably a bit of my fault too since it uses polendina .. which is mine and then, after all that, we'll need to semver-major this because of the drop of support for older version of Node.js |
Thanks for the detailed response @rvagg . Do we have some ETA for getting this fixed? |
@rvagg Is this repo still under maintenance / is this issue something that can be addressed / do you need help? |
if someone wants to help push this forward, I'd like to switch CI to use the same as in bl, https://github.com/rvagg/bl/tree/master/.github/workflows; having a failing CI means I can't merge this |
Upgrade semver of readable-stream from 3 to 4.2.0