Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade semver of readable-stream from 3 to ^4.0.0 #113

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Annniee1
Copy link

@Annniee1 Annniee1 commented Nov 21, 2022

Upgrade semver of readable-stream from 3 to 4.2.0

@Annniee1
Copy link
Author

@brycebaril @maxogden @rvagg @styfle Please Have a look at this PR

package.json Outdated
@@ -23,7 +23,7 @@
"author": "Rod Vagg <[email protected]> (https://github.com/rvagg)",
"license": "MIT",
"dependencies": {
"readable-stream": "3"
"readable-stream": "4.2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"readable-stream": "4.2.0"
"readable-stream": "4"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Done. Please Review It @styfle

@Annniee1 Annniee1 changed the title Upgrade semver of readable-stream from 3 to 4.2.0 Upgrade semver of readable-stream from 3 to ^4.0.0 Nov 22, 2022
Copy link
Contributor

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine although I don't have any authority here and didn't run the tests

@Annniee1
Copy link
Author

@rvagg Please Review this PR

@rvagg
Copy link
Owner

rvagg commented Nov 30, 2022

🤦 CI is very out of date ...

for a start, let's go with ^4.2.0, but secondly we need to fix CI, which means ditching 8.x->12.x; perhaps copy this matrix: https://github.com/rvagg/bl/blob/master/.github/workflows/test-and-release.yml#L8

also the browser tests are broken, probably a bit of my fault too since it uses polendina .. which is mine

and then, after all that, we'll need to semver-major this because of the drop of support for older version of Node.js

@Annniee1
Copy link
Author

Annniee1 commented Dec 7, 2022

Thanks for the detailed response @rvagg . Do we have some ETA for getting this fixed?
We are using string_decoder in our project,. In our project, We are getting compliance issues for string_decoder dependency which is getting pulled this way, through2 -> readable-stream -> string_decoder.
Do we have some way to get the required version of through2 which pulls [email protected].
Looking forward to get some more understanding regarding this.
@rvagg @Delapouite @maxogden @styfle

@legobeat
Copy link

@rvagg Is this repo still under maintenance / is this issue something that can be addressed / do you need help?

@rvagg
Copy link
Owner

rvagg commented Aug 7, 2023

if someone wants to help push this forward, I'd like to switch CI to use the same as in bl, https://github.com/rvagg/bl/tree/master/.github/workflows; having a failing CI means I can't merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants