Add disclosure for hasbrown's borsh encoding #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a proposal to release the fix as 0.15.1 and just yank 0.15.0, so, might be worth verifying which of the two versions is going to be used for the fix. |
It's unclear with what version it will be and when it will be. I'd prefer to make this valid and file-able now than risk someone starting to use this functionality (which will make removing it more complicated).
|
I've removed the patched notice so this can be filed now (warning other people off from adopting this functionality) while we continue to wait for a patched version. |
|
Sorry for my delay in updating this. It correctly notes when patched now. |
kornelski
approved these changes
Dec 4, 2024
Turbo87
reviewed
Dec 4, 2024
|
|
||
| [versions] | ||
| patched = [">= 0.15.1"] | ||
| unaffected = ["<= 0.14"] |
There was a problem hiding this comment.
I'm not sure how this is supposed to be interpreted, but at least cargo-deny flags 0.14.5 as being affected now. Maybe unaffected = ["< 0.15.0"] would be better?
There was a problem hiding this comment.
I've opened #2157 with that proposal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this as fixed in 0.16 due to that being the plan documented here: rust-lang/hashbrown#570 (comment)
Until that PR is merged and 0.16 is released, this cannot be merged/must be edited to be described as unpatched.