Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow construction with HttpConnector and default ClientConfig #107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

inikulin
Copy link

@inikulin inikulin commented Apr 1, 2020

Closes: #67

@lucab lucab changed the title Allow construction with HttpConnector and default ClientConfig (closes #67) Allow construction with HttpConnector and default ClientConfig Apr 1, 2020
@inikulin inikulin force-pushed the gh-67 branch 2 times, most recently from fb04d58 to f7bb45c Compare April 2, 2020 10:14
@inikulin
Copy link
Author

inikulin commented Apr 2, 2020

Something is wrong with the CI for MacOS - builds get cancelled right away. It's definitely unrelated to the PR.

@kinosang
Copy link

kinosang commented Aug 1, 2020

@inikulin
Copy link
Author

inikulin commented Aug 2, 2020

@kinosang thanks for the suggestion and we looked into it, but we'd like to stick with hyper-rustls in our project.

@kinosang
Copy link

kinosang commented Aug 2, 2020

@inikulin yeah, I mean, to uniformize the APIs, we may have a new_with_connector() for hyper-rustls instead of a default_client_config.

@inikulin
Copy link
Author

inikulin commented Aug 2, 2020

This is what I did initially, however later we've had a case where we needed to do minor adjustments to the default config and this API is flexible enough to support that.

@ghost
Copy link

ghost commented May 31, 2021

@inikulin please rebase

@lucab @ctz could you have a look at this PR? I need exactly the same thing and this looks like an easy change.

ghost pushed a commit to nyantec/hyper-rustls that referenced this pull request May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow construction with HttpConnector and default ClientConfig
2 participants