-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Error for OidParseError #39
base: master
Are you sure you want to change the base?
Implement Error for OidParseError #39
Conversation
31fd707
to
72c81a2
Compare
src/asn1_types/oid.rs
Outdated
#[cfg_attr(feature = "std", error("Relative OIDs must not be empty"))] | ||
RelativeTooShort, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be implemented without adding the new variant? It's a semver breaking change with this approach and it feels like the value of the separate RelativeTooShort
variant might not justify it. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right I forgot to keep semver in mind. Of course we don't need to introduce a breaking change for this.
Fixed it.
Only available with 'std' feature.
72c81a2
to
5bea3e1
Compare
So is there anything else I can do to finish/merge this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chifflier I think this is ready for review if you have a chance. It seems like a reasonable diff to me.
Hi, Previously, this crate was doing the same, but ended up choosing At this point, I am unsure what solution is best. Any thoughts on this? |
The real value of
|
While using your excellent crate I noticed that
OidParseError
does not implementError
. I can see that inno_std
environments this is not required but for many cases this is a low-hanging nice-to-have.This PR implements the
Error
trait forstd
builds.