Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic texenv APIs and fully safe triangle example (!) #33

Merged
merged 6 commits into from
Dec 5, 2023
Merged

Add basic texenv APIs and fully safe triangle example (!) #33

merged 6 commits into from
Dec 5, 2023

Conversation

ian-h-chamberlain
Copy link
Member

@ian-h-chamberlain ian-h-chamberlain commented Nov 26, 2023 •
edited
Loading

Nice, we're starting to get somewhere. Probably worth a follow-up PR to finish out the rest of the texenv API, or could do it in this one.

TODO:

  • manual testing the example it seems like it's not working anymore in Citra, but probably worth testing on hardware to double check and fix whatever broke

@ian-h-chamberlain
Build fix for libctru 2.2.x
30964ba
@ian-h-chamberlain
Minor cleanups
0fbd441
@ian-h-chamberlain
Fixup right-handed coordinates and projection API
3127289 
Since it's a builder, we should really consume self and return Self
instead of using &mut self. This makes it easier to convert into the
final matrix at the end of building.
@ian-h-chamberlain ian-h-chamberlain marked this pull request as ready for review November 30, 2023 14:38
@ian-h-chamberlain ian-h-chamberlain merged commit b02384f into main Dec 5, 2023
4 checks passed
@ian-h-chamberlain ian-h-chamberlain deleted the feature/texenv branch December 5, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ian-h-chamberlain