-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build multiple 3DSX files (one per cargo artifact) #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For each executable artifact generated by the build command, run the build callback on it. Then, if there is only one artifact, run the run/test callback on it.
Meziu
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with the target configuration in Cargo.toml
! I hope to see the ability to run swarms of examples in the near future 😄.
Only test/run need to fail for multiple executables. We can also handle custom runners in the same logic and pull it out from the callbacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44
Trying again for #58 ! I think this is a bit cleaner / less churn vs what I had there.
Two main components here:
CTRConfig
implementDeserialize
, and use that to parse metadata instead of manually walking theCargo.toml
. We already collected the metadata once, so we can just pass it through everywhere.TODOs:
Maybe if a custom runner forcargo 3ds test
is specified, we should do the normal cargo thing and run all the executables in sequence? This would be nice for our CI etc.Nvm, I forgot that for custom runner Cargo does the running, not
cargo-3ds
. I should file a separate issue to see if we can build the 3dsx before invoking the runner though... When a custom runner is used, see if we can build 3dsx before the runner is invoked #61