Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MacOS (Cgl) make_current_surfaceless() implementation #1710

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

bschwind
Copy link
Contributor

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

I have tested this on a complex OpenGL application which uses multiple "surfaceless" contexts on many threads while sharing textures and having those textures displayed on the main thread with a windowed OpenGL context, and everything appears to function correctly.

Copy link
Member

@kchibisov kchibisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--

next time would suggest to re-request review (ui on the right).

@bschwind
Copy link
Contributor Author

next time would suggest to re-request review (ui on the right).

Roger that!

@kchibisov kchibisov merged commit 9c58fbb into rust-windowing:master Oct 28, 2024
43 checks passed
@bschwind bschwind deleted the macos-surfaceless branch October 28, 2024 06:03
@kchibisov
Copy link
Member

There's also the same APIs for glx/wgl from what I can tell, so we may have it at top-level at some point.

it's just they both need extensions, so display feature may be needed for users to configure their pipeline beforehand.

@bschwind
Copy link
Contributor Author

There's also the same APIs for glx/wgl from what I can tell, so we may have it at top-level at some point.

Yep, a colleague of mine has added similar functionality for glx, so we'll probably have another PR up for that soon. I currently don't have a windows machine so I can't test wgl at the moment, but hopefully I'll get one soon.

@kchibisov
Copy link
Member

wgl should be the same as glx since they were designed by the same process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants