Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added serde feature #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JonathanWoollett-Light
Copy link
Contributor

@JonathanWoollett-Light JonathanWoollett-Light commented May 31, 2022

Summary of the PR

Added serde support via a feature that derives Serialize and Deserialize for IdAllocator and AddressAllocator (and contained types). This should in the future allow exact restoration of IdAllocator and AddressAllocator from a stored version. I would suggest it is just best practice to derive Serialize and Deserialize for crate public types (like Debug). This change should have no affect (including compile time) to the existing code base.

You may wish to change the documentation to build with cargo rustdoc --all-features but I was unsure what changes to make here and how to annotate them.

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR are signed (with git commit -s), and the commit
    message has max 60 characters for the summary and max 75 characters for each
    description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • Any newly added unsafe code is properly documented.

@JonathanWoollett-Light JonathanWoollett-Light marked this pull request as draft May 31, 2022 16:35
@AlexandruCihodaru AlexandruCihodaru self-requested a review May 31, 2022 16:36
Signed-off-by: Jonathan Woollett-Light <[email protected]>
@JonathanWoollett-Light JonathanWoollett-Light marked this pull request as ready for review May 31, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant