Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Added serde support via a feature that derives
Serialize
andDeserialize
forIdAllocator
andAddressAllocator
(and contained types). This should in the future allow exact restoration ofIdAllocator
andAddressAllocator
from a stored version. I would suggest it is just best practice to deriveSerialize
andDeserialize
for crate public types (likeDebug
). This change should have no affect (including compile time) to the existing code base.You may wish to change the documentation to build with
cargo rustdoc --all-features
but I was unsure what changes to make here and how to annotate them.Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s
), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
unsafe
code is properly documented.