Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOGs: uniform and fix some inconsistencies #274

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

stefano-garzarella
Copy link
Member

Summary of the PR

Every time I do a release I notice this difference between
changelogs in this workspace, so let's try to uniform them by using
the form used in vhost-user-backend: without square brackets in the
title of the release and the v as prefix (v0.0.0).

Also fixed some difference in how we link PRs, let's follow the
most used way: [#000]

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

This version got yanked because the `gpu_socket` feature introduced
in this release was causing problems
(see [rust-vmm#265](rust-vmm#265)).
Starting with the next version (v0.16.1), the `gpu_socket`
feature was removed.

Signed-off-by: Stefano Garzarella <[email protected]>
This version got yanked because the `gpu_socket` feature introduced
in this release was causing problems
(see [rust-vmm#265](rust-vmm#265)).
Starting with the next version (v0.16.1), the `gpu_socket`
feature was removed.

Signed-off-by: Stefano Garzarella <[email protected]>
Every time I do a release I notice this difference between
changelogs in this workspace, so let's try to uniform them by using
the form used in vhost-user-backend: without square brackets in the
title of the release and the `v` as prefix (v0.0.0).

Also fixed some difference in how we link PRs, let's follow the
most used way: [[#000]](url)

Signed-off-by: Stefano Garzarella <[email protected]>
@stefano-garzarella
Copy link
Member Author

stefano-garzarella commented Oct 25, 2024

I based this on top of #273 so we don't need to fix the conflicts. Marking as draft till we have it merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant