Clean up unused MSHV_CHECK_EXTENSION and re-defined __IncompleteArrayField #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This struct is already defined in the generated bindings.rs. Signed-off-by: Nuno Das Neves <[email protected]>
check_stable() and the associated IOCTL, MSHV_CHECK_EXTENSION, are not currently in use, and will be replaced in a future patch. Signed-off-by: Nuno Das Neves <[email protected]>
NunoDasNeves
requested review from
russell-islam,
liuw and
jinankjain
as code owners
jinankjain
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSHV_CHECK_EXTENSIONwill soon be replaced, so remove it here ahead of time. The associated functioncheck_stable()is not used in any case.__IncompleteArrayFieldand I was getting a compiler warning about it being defined twice - it should only be defined inbindings.rsAFAIK.