Poisson u64 sampling #1498
Merged
Poisson u64 sampling #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhardy
reviewed
Sep 28, 2024
dhardy
approved these changes
Sep 28, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
This addresses #1497 by adding
Distribution<u64>It also solves #1312 by not allowing
lambdabigger than1.844e19(this also makes them always fit intou64)Details
The
Distribution<u64>is a breaking change and will have a bit of negative impact on the call side, because it requires sometimes type annotations.Alternatively we keep the maximum lambda and document that it is always safe to just
as u64on the samples if required.