-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic support for axis simplification and arbitrary order in iterators #979
Open
bluss
wants to merge
8
commits into
master
Choose a base branch
from
iterator-order
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+472
−16
Commits on Mar 31, 2024
-
FIX: Make internal iterator types and functions pub(crate)
These `pub` here actually predate the pub(crate) feature, and they should just be `pub(crate)` or lower since they are unreachable outside the crate.
Configuration menu - View commit details
-
Copy full SHA for 1a8377e - Browse repository at this point
Copy the full SHA 1a8377eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 572dea0 - Browse repository at this point
Copy the full SHA 572dea0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d223bc6 - Browse repository at this point
Copy the full SHA d223bc6View commit details -
TEST: Add iteration and sum (fold) benchmarks for row/col matrices
This is special for arrays of shape 1 x n or n x 1; add iterator and iterator sum (fold) benchmarks.
Configuration menu - View commit details
-
Copy full SHA for 9438d93 - Browse repository at this point
Copy the full SHA 9438d93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21df00f - Browse repository at this point
Copy the full SHA 21df00fView commit details -
FEAT: Implement order optimizations for Baseiter
Implement axis merging - this preserves order of elements in the iteration but might simplify iteration. For example, in a contiguous matrix, a shape like [3, 4] can be merged into [1, 12]. Also allow arbitrary order optimization - we then try to iterate in memory order by sorting all axes, currently.
Configuration menu - View commit details
-
Copy full SHA for a3d26b6 - Browse repository at this point
Copy the full SHA a3d26b6View commit details -
MAINT: Allow another clippy lint
This one complains about if let Some(_) = option; which I still think is just as fine as if option.is_some(); `if let` is a nice Rust feature that works the same way on all enums, no reason to prefer option-specific methods like `is_some`.
Configuration menu - View commit details
-
Copy full SHA for 1e05bae - Browse repository at this point
Copy the full SHA 1e05baeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d9ce5e - Browse repository at this point
Copy the full SHA 4d9ce5eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.