-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ndk: Add bindings for AFont #397
Conversation
TODOs
|
Nice! I'll pull in the bindings regeneration via #370, and then have a look at this. |
Co-authored-by: Marijn Suijten <[email protected]>
Co-authored-by: Marijn Suijten <[email protected]>
Co-authored-by: Marijn Suijten <[email protected]>
Co-authored-by: Marijn Suijten <[email protected]>
@paxbun any updates or should I apply the remaining comments/remarks/suggestions and merge this? I'd like to get the "breaking" changes imposed by the |
Co-authored-by: Marijn Suijten <[email protected]>
@MarijnS95 I think I mostly applied your suggestion, and I also checked whether there are any |
Note that I reported the header issues at android/ndk#1920, because Hopefully we can drop the workarounds when upstream picks them up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marked most of the conversations as resolved, nice job clearing it all up!
I only have nits now, and if you fix the conflicts to make the CI run it might have a complaint or two, but after that I'll merge this in!
Co-authored-by: Marijn Suijten <[email protected]>
I applied all the suggestions you mentioned! (except for the axis tag one) |
This PR provides bindings for
AFont
,AFontMatcher
, andASystemFontIterator
and some helper structs for the better abstraction of some parts of the OpenType specification.Example:
Result (Tested on Galaxy Tab S8):