Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider either re-exporting ndk crate or encapsulating the ndk crate API #45

Open
rib opened this issue Dec 4, 2022 · 0 comments
Open

Comments

@rib
Copy link
Collaborator

rib commented Dec 4, 2022

Similar to how the Winit crate re-exports the android-activity API it could make sense for this crate to re-export the ndk crate's API so that downstream crates don't need to have an explicit ndk dependency in their Cargo.toml whose version needs to be synchronized with android-activity in case they want to use types (like AssetManager and NativeWindow that are exposed in the public API for android-activity)

(In the case the we re-export the ndk crate that would only really be convenient if the Winit crate were to also do the same, and forward the ndk API from android-activity)

Alternatively the ndk API could be fully encapsulated as an internal implementation detail by defining our own new types for the Asset Manager and Native Window.

Ref: bevyengine/bevy#6830 + bevyengine/bevy#6830 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant