We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keycode
There's a notable portability hazard currently due to the game-activity and native-activity backends exposing different Keycode types.
game-activity
native-activity
For example rust-windowing/winit@9184309#diff-9169a22d6397a250be741006cd857b8a575f804c74cc07e3a4fb8f3341606d9b and rust-windowing/winit@4a36741 both recently assumed they could use the ndk::event::Keycode type which inadvertently broke building Winit against the game-activity backend.
ndk::event::Keycode
We should either use ndk::event::Keycode in both backends or move the current game-activity Keycode type so it can be shared.
Also relates to #45
The text was updated successfully, but these errors were encountered:
Perhaps also relates to #48 when considering reusing ndk types that look/feel too similar to their game-activity counterpart.
ndk
We could even rewrite parts of the C code to make them similar if desired.
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
There's a notable portability hazard currently due to the
game-activity
andnative-activity
backends exposing differentKeycode
types.For example rust-windowing/winit@9184309#diff-9169a22d6397a250be741006cd857b8a575f804c74cc07e3a4fb8f3341606d9b and rust-windowing/winit@4a36741 both recently assumed they could use the
ndk::event::Keycode
type which inadvertently broke building Winit against thegame-activity
backend.We should either use
ndk::event::Keycode
in both backends or move the currentgame-activity
Keycode
type so it can be shared.Also relates to #45
The text was updated successfully, but these errors were encountered: