Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use common Keycode type across backends #92

Closed
rib opened this issue Jun 27, 2023 · 1 comment · Fixed by #107
Closed

Use common Keycode type across backends #92

rib opened this issue Jun 27, 2023 · 1 comment · Fixed by #107

Comments

@rib
Copy link
Collaborator

rib commented Jun 27, 2023

There's a notable portability hazard currently due to the game-activity and native-activity backends exposing different Keycode types.

For example rust-windowing/winit@9184309#diff-9169a22d6397a250be741006cd857b8a575f804c74cc07e3a4fb8f3341606d9b and rust-windowing/winit@4a36741 both recently assumed they could use the ndk::event::Keycode type which inadvertently broke building Winit against the game-activity backend.

We should either use ndk::event::Keycode in both backends or move the current game-activity Keycode type so it can be shared.

Also relates to #45

@MarijnS95
Copy link
Member

Perhaps also relates to #48 when considering reusing ndk types that look/feel too similar to their game-activity counterpart.

We could even rewrite parts of the C code to make them similar if desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants