Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use roles for compiler team maintainers #1609

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

davidtwco
Copy link
Member

  • Allow alumni to have roles as the compiler team want to recognise the team member for the role they had while active
  • Remove compiler team maintainer subteam and add these as roles to the team members

This enables the compiler team to recognise their alumni for the role
that they held while active.
@davidtwco
Copy link
Member Author

davidtwco commented Nov 12, 2024

Needs rust-lang/www.rust-lang.org#2088 to show the alumni roles on the website, but this needs merged first

@@ -478,6 +474,10 @@ impl Team {
&self.people.members
}

pub(crate) fn explicit_alumni(&self) -> &[TeamMember] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand the explicit_alumni naming (as opposed to just alumni). Can you explain why that's preferable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants