Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate archived repos #1527

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

validate archived repos #1527

wants to merge 1 commit into from

Conversation

MarcoIeni
Copy link
Member

@MarcoIeni MarcoIeni commented Aug 20, 2024 •
edited
Loading

@MarcoIeni MarcoIeni mentioned this pull request Aug 20, 2024
Merged
@Kobzol
Copy link
Contributor

Kobzol commented Aug 20, 2024 •
edited
Loading

Good idea, I wanted to do this a few times but always forgot (or probably just got lazy, lol). Could you also please validate that the archive directory does not contain any files? So that we also make sure that people don't put TOML files directly into the directory, rather than into archive/rust-lang, like you did by accident in the recent PR.

@MarcoIeni
Copy link
Member Author

Could you also please validate that the archive directory does not contain any files?

I'll do this in a separate PR 👍

MarcoIeni
MarcoIeni commented Aug 21, 2024
View reviewed changes
tests/static-api/repos/archive/test-org/archived_repo.toml
@@ -4,7 +4,6 @@ description = "An archived repo!"
bots = []

[access.teams]
foo = "admin"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to remove this because tests were failing

@MarcoIeni MarcoIeni marked this pull request as ready for review August 21, 2024 08:20
@MarcoIeni MarcoIeni mentioned this pull request Aug 21, 2024
Closed
@MarcoIeni
Copy link
Member Author

Opened a new issue to discuss the path validation: #1528

@Kobzol Kobzol requested a review from rylev September 28, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylev rylev Awaiting requested review from rylev

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcoIeni @Kobzol