Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dummy value locals for function ptr calls #554

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

sapir
Copy link
Contributor

@sapir sapir commented Aug 7, 2024

This makes the generated code cleaner so it's easier to debug.

@GuillaumeGomez
Copy link
Member

Nice improvement!

@antoyo
Copy link
Contributor

antoyo commented Aug 7, 2024

I believe I had a good reason to do this.
You can see where I did this here.

I'm not sure I remember correctly, but this was certainly for debugging reasons, possibly to clearly indicate that this value is never used because I might have thought otherwise at the time.

This is possibly not needed anymore, though.

@antoyo antoyo merged commit 2cc32ba into rust-lang:master Aug 7, 2024
34 checks passed
@antoyo
Copy link
Contributor

antoyo commented Aug 7, 2024

Thanks for your contribution!

@sapir sapir deleted the remove-void-func-debug-var branch August 7, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants