Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed UI tests by only keeping the check, build and run pass #550

Closed
wants to merge 1 commit into from

Conversation

ibilalkayy
Copy link

Hey there, I just went through this whole file by checking whether these tests are missing.

This issue was mentioned here.

  • //@ check-pass
  • //@ build-pass
  • //@ run-pass

And I found the following files that were missing all three of them.

Line No. 34 - tests/ui/parser/unclosed-delimiter-in-dep.rs
Line No. 35 - tests/ui/consts/missing_span_in_backtrace.rs
Line No. 63 - tests/ui/async-await/in-trait/dont-project-to-specializable-projection.rs
Line No. 64 - tests/ui/consts/try-operator.rs
Line No. 68 - tests/ui/consts/issue-miri-1910.rs
Line No. 71 - tests/ui/consts/issue-73976-monomorphic.rs
Line No. 72 - tests/ui/consts/issue-94675.rs
Line No. 73 - tests/ui/rfcs/rfc-2632-const-trait-impl/const-drop-fail.rs
Line No. 93 - tests/ui/consts/const-eval/parse_ints.rs

@antoyo
Copy link
Contributor

antoyo commented Aug 5, 2024

Hi.
Thanks for your contribution.

This issue was mentioned here.

  • //@ check-pass
  • //@ build-pass
  • //@ run-pass

The above is the desired behavior, not the current behavior. You will need to update the code around here in order to get this desired behavior.

@ibilalkayy
Copy link
Author

Hey @antoyo, is this PR worthy or should I close this PR and just write this

  • //@ check-pass
  • //@ build-pass
  • //@ run-pass

in place of this.

  • //@ error-pattern",
  • //@ build-fail
  • //@ run-fail

@antoyo
Copy link
Contributor

antoyo commented Aug 5, 2024

I don't think this will work since that function is used to remove the tests with errors while we want to keep the tests without errors, so you'll probably need to invert a condition somewhere in addition to doing this.

@ibilalkayy
Copy link
Author

ibilalkayy commented Aug 6, 2024

First of all, I request you to keep your English simple. I am not a native speaker.

Now there are two things that I understood and maybe I am wrong in this.

  1. I went through all the test files that did not have the pass markers and I removed those files because a person asked this in the issue and you said yes.

  2. Now in the comment, you said that these pass markers are not the current behavior. They are the desired behavior. So I thought maybe I needed to update them.

Hi. Thanks for your contribution.

This issue was mentioned here.

  • //@ check-pass
  • //@ build-pass
  • //@ run-pass

The above is the desired behavior, not the current behavior. You will need to update the code around here to get this desired behavior.

Now my question is, should I keep these changes and update this file with the pass markers?

If nothing above is required then just give me an idea in simple words because I didn't understand this point that you want to keep the test with errors.

I don't think this will work since that function is used to remove the tests with errors while we want to keep the tests without errors, so you'll probably need to invert a condition somewhere in addition to doing this.

I will be happy to contribute.

Thank you!

@ibilalkayy ibilalkayy closed this by deleting the head repository Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants