Consider more erroneous layouts as LayoutError::ReferencesError to suppress spurious errors
#135264
+111
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
lukas-code
reviewed
Jan 8, 2025
|
sure thing 👍 |
bors
added
S-waiting-on-author
…ppress spurious errors
compiler-errors
force-pushed
the
layout-propagate-errors
branch
from
5a72651 to
b89a6e4
Compare
|
Added the other errors, which indeed did ICE @bors r=oli-obk |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 14, 2025
…rrors, r=oli-obk Consider more erroneous layouts as `LayoutError::ReferencesError` to suppress spurious errors Fixes rust-lang#135208 r? oli-obk
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 14, 2025
…rrors, r=oli-obk Consider more erroneous layouts as `LayoutError::ReferencesError` to suppress spurious errors Fixes rust-lang#135208 r? oli-obk
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 15, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#134940 (Make sure to scrape region constraints from deeply normalizing type outlives assumptions in borrowck) - rust-lang#135047 (Add gpu-kernel calling convention) - rust-lang#135228 (Improve `DispatchFromDyn` and `CoerceUnsized` impl validation) - rust-lang#135264 (Consider more erroneous layouts as `LayoutError::ReferencesError` to suppress spurious errors) - rust-lang#135302 (for purely return-type based searches, deprioritize clone-like functions) - rust-lang#135380 (Make sure we can produce `ConstArgHasWrongType` errors for valtree consts) - rust-lang#135425 (Do not consider traits that have unsatisfied const conditions to be conditionally const) r? `@ghost` `@rustbot` modify labels: rollup
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Jan 15, 2025
…rrors, r=oli-obk Consider more erroneous layouts as `LayoutError::ReferencesError` to suppress spurious errors Fixes rust-lang#135208 r? oli-obk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #135208
r? oli-obk