Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make -Csoft-float have an effect on all ARM targets #134885

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Dec 29, 2024

See the discussion on Zulip: apparently -float-abi=soft is how one can force "use soffloat ABI but hardware FP instructions" on ARM-32. Our version of that is -Csoft-float but I made that one a NOP on all targets except for ARM eabihf (see #129897)... which now make experimentation on what we actually want to do here a lot harder. So, let's unlock the flag on all ARM targets while we are still figuring out our long-term plans here.

Cc @workingjubilee

@rustbot
Copy link
Collaborator

rustbot commented Dec 29, 2024

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 29, 2024
@RalfJung
Copy link
Member Author

Though even on old rustc I haven't actually found an example where this flag changes anything for non-eabihf targets...

@workingjubilee
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 29, 2024

📌 Commit 62bb35a has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2024
@workingjubilee
Copy link
Member

( I'm pretty sure this makes the flag unsound again but hey it was unsound for years. )

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 30, 2024
…bilee

make -Csoft-float have an effect on all ARM targets

See the discussion [on Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187780-t-compiler.2Fwg-llvm/topic/Softfloat.20ABI.2C.20hardfloat.20instructions): apparently `-float-abi=soft` is how one can force "use soffloat ABI but hardware FP instructions" on ARM-32. Our version of that is `-Csoft-float` but I made that one a NOP on all targets except for ARM eabihf (see rust-lang#129897)... which now make experimentation on what we actually want to do here a lot harder. So, let's unlock the flag on all ARM targets while we are still figuring out our long-term plans here.

Cc `@workingjubilee`
@bors
Copy link
Contributor

bors commented Dec 30, 2024

⌛ Testing commit 62bb35a with merge cab3ea9...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-apple-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
test [mir-opt] tests/mir-opt/unusual_item_types.rs ... ok

failures:

---- [mir-opt] tests/mir-opt/strip_debuginfo.rs#TINY stdout ----
thread '[mir-opt] tests/mir-opt/strip_debuginfo.rs#TINY' panicked at src/tools/compiletest/src/runtest.rs:213:30:
called `Result::unwrap()` on an `Err` value: Os { code: 17, kind: AlreadyExists, message: "File exists" }


failures:
    [mir-opt] tests/mir-opt/strip_debuginfo.rs#TINY

@bors
Copy link
Contributor

bors commented Dec 30, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 30, 2024
@RalfJung
Copy link
Member Author

@bors retry tests/mir-opt/strip_debuginfo.rs#TINY "File exists"

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 30, 2024
@bors
Copy link
Contributor

bors commented Dec 30, 2024

⌛ Testing commit 62bb35a with merge f95c996...

@bors
Copy link
Contributor

bors commented Dec 30, 2024

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing f95c996 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 30, 2024
@bors bors merged commit f95c996 into rust-lang:master Dec 30, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 30, 2024
@RalfJung RalfJung deleted the arm-soft-float branch December 30, 2024 16:05
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f95c996): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -1.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.8% [-2.2%, -1.4%] 3
All ❌✅ (primary) - - 0

Cycles

Results (secondary 2.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.6% [2.2%, 2.9%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 759.791s -> 761.456s (0.22%)
Artifact size: 325.54 MiB -> 325.54 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants