-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make -Csoft-float have an effect on all ARM targets #134885
Conversation
Though even on old rustc I haven't actually found an example where this flag changes anything for non-eabihf targets... |
@bors r+ rollup |
( I'm pretty sure this makes the flag unsound again but hey it was unsound for years. ) |
…bilee make -Csoft-float have an effect on all ARM targets See the discussion [on Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187780-t-compiler.2Fwg-llvm/topic/Softfloat.20ABI.2C.20hardfloat.20instructions): apparently `-float-abi=soft` is how one can force "use soffloat ABI but hardware FP instructions" on ARM-32. Our version of that is `-Csoft-float` but I made that one a NOP on all targets except for ARM eabihf (see rust-lang#129897)... which now make experimentation on what we actually want to do here a lot harder. So, let's unlock the flag on all ARM targets while we are still figuring out our long-term plans here. Cc `@workingjubilee`
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
@bors retry tests/mir-opt/strip_debuginfo.rs#TINY "File exists" |
☀️ Test successful - checks-actions |
Finished benchmarking commit (f95c996): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -1.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 2.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 759.791s -> 761.456s (0.22%) |
See the discussion on Zulip: apparently
-float-abi=soft
is how one can force "use soffloat ABI but hardware FP instructions" on ARM-32. Our version of that is-Csoft-float
but I made that one a NOP on all targets except for ARM eabihf (see #129897)... which now make experimentation on what we actually want to do here a lot harder. So, let's unlock the flag on all ARM targets while we are still figuring out our long-term plans here.Cc @workingjubilee